Home
My Posts

Archive
Login
Signup

Recent Posts

Free subdomains

Want your own xyz.kpaste.net sub-domain for your community? Just type the address into your browser address bar (foo.xyz.kpaste.net is also supported).

Suggestions/Bugs?

Email us at . Try to include as much info as possible.

About

Pastebin is a tool for collaborative debugging or editing.

 

msnfs41client: Patches for ReactOS clang warning fixes, debugger attach+misc, 2025-01-31
Posted by Anonymous on Fri 31st Jan 2025 15:49
raw | new post

Submit a correction or amendment below (click here to make a fresh posting)
After submitting an amendment, you'll be able to view the differences between the old and new posts easily.

Syntax highlighting: None Bash C C++ CSS Diff HTML mIRC Script Perl PHP Python Smarty XML ---------------------------- ABAP Actionscript ADA Apache Log AppleScript APT sources.list ASM ASP AutoIT Bash C C# C++ C++ (with QT) CSS Diff HTML INI (Config Files) Java Javascript Lua Make mIRC Script MySQL NSIS Perl PHP Python Q(uick)BASIC robots Ruby Ruby on Rails SDLBasic Smarty SQL TCL Text VB.NET Visual BASIC Visual Fox Pro Visual Prolog Windows Registry Files XML Xorg.conf

To highlight particular lines, prefix each line with {%HIGHLIGHT}
From db214ce35f0578424ef117057a23e65f27d497cc Mon Sep 17 00:00:00 2001 From: Dan Shelton <dan.f.shelton@gmail.com> Date: Fri, 31 Jan 2025 13:35:58 +0100 Subject: [PATCH 1/5] daemon: Fix clang "warning : 'extern' variable has an initializer" warning Fix clang "warning : 'extern' variable has an initializer" warning. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com> --- daemon/daemon_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/daemon_debug.c b/daemon/daemon_debug.c index cb56e92..03eeda7 100644 --- a/daemon/daemon_debug.c +++ b/daemon/daemon_debug.c @@ -35,7 +35,7 @@ #include "rpc/auth_sspi.h" #include "accesstoken.h" -extern int g_debug_level = DEFAULT_DEBUG_LEVEL; +int g_debug_level = DEFAULT_DEBUG_LEVEL; void set_debug_level(int level) { g_debug_level = level; } -- 2.45.1 From 3fd2eac909fafae5140af3655e2c219b7dedbf90 Mon Sep 17 00:00:00 2001 From: Dan Shelton <dan.f.shelton@gmail.com> Date: Fri, 31 Jan 2025 13:56:53 +0100 Subject: [PATCH 2/5] daemon: Fix clang "warning : passing 'char **' to parameter of type 'const char **' discards qualifiers in nested pointer types" Fix clang "warning : passing 'char **' to parameter of type 'const char **' discards qualifiers in nested pointer types". Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com> --- daemon/symlink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/daemon/symlink.c b/daemon/symlink.c index 357a009..268e987 100644 --- a/daemon/symlink.c +++ b/daemon/symlink.c @@ -198,7 +198,12 @@ static int parse_symlink(unsigned char *buffer, uint32_t length, nfs41_upcall *u if (status) goto out; if (args->set) - status = get_name(&buffer, &length, &args->target_set); + /* + * args->target_set is not const because handle_symlink() might + * have to replace '\\' with '/' + */ + status = get_name(&buffer, &length, + (const char **)(&args->target_set)); else args->target_set = NULL; -- 2.45.1 From a642b6b6ac4ea401422d906d34ba073a8cf6b9d4 Mon Sep 17 00:00:00 2001 From: Dan Shelton <dan.f.shelton@gmail.com> Date: Fri, 31 Jan 2025 14:02:41 +0100 Subject: [PATCH 3/5] daemon: Fix clang "warning : using the result of an assignment as a condition without parentheses" Fix clang "warning : using the result of an assignment as a condition without parentheses". Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com> --- daemon/delegation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/delegation.c b/daemon/delegation.c index 22f1009..7401bc4 100644 --- a/daemon/delegation.c +++ b/daemon/delegation.c @@ -299,7 +299,7 @@ static int delegation_return( out_downcall: /* recover opens and locks associated with the delegation */ - while (open = deleg_open_find(&client->state, deleg)) { + while ((open = deleg_open_find(&client->state, deleg)) != NULL) { status = nfs41_delegation_to_open(open, try_recovery); if (status == NFS4_OK) status = delegation_flush_locks(open, try_recovery); -- 2.45.1 From 0f50910772da3ac0fd767943ff76c4467f600173 Mon Sep 17 00:00:00 2001 From: Roland Mainz <roland.mainz@nrubsig.org> Date: Fri, 31 Jan 2025 15:41:14 +0100 Subject: [PATCH 4/5] tests: nfsbuildtest "bash build" subcmd should use -j16 nfsbuildtest.ksh93 subcmd "bash build" should use -j16 Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com> --- tests/nfsbuildtest/nfsbuildtest.ksh93 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/nfsbuildtest/nfsbuildtest.ksh93 b/tests/nfsbuildtest/nfsbuildtest.ksh93 index e86a1f1..3f3e653 100644 --- a/tests/nfsbuildtest/nfsbuildtest.ksh93 +++ b/tests/nfsbuildtest/nfsbuildtest.ksh93 @@ -331,15 +331,15 @@ function bash_build # if $config_use_posix_ksh93_builtins ; then if is_cygwin && (( (cygwin_vers.major*1000+cygwin_vers.minor) >= 3005 )) ; then - time ksh93 -c 'export SHELL=/bin/ksh93 ; bmake -j8 install DESTDIR=$PWD/install_root' + time ksh93 -c 'export SHELL=/bin/ksh93 ; bmake -j16 install DESTDIR=$PWD/install_root' else - time ksh93 -c 'export SHELL=/bin/ksh93 ; make -j8 install DESTDIR=$PWD/install_root' + time ksh93 -c 'export SHELL=/bin/ksh93 ; make -j16 install DESTDIR=$PWD/install_root' fi else if is_cygwin && (( (cygwin_vers.major*1000+cygwin_vers.minor) >= 3005 )) ; then - time bash -c 'export SHELL=/bin/bash ; bmake -j8 install DESTDIR=$PWD/install_root' + time bash -c 'export SHELL=/bin/bash ; bmake -j16 install DESTDIR=$PWD/install_root' else - time bash -c 'export SHELL=/bin/bash ; make -j8 install DESTDIR=$PWD/install_root' + time bash -c 'export SHELL=/bin/bash ; make -j16 install DESTDIR=$PWD/install_root' fi fi echo $? -- 2.45.1 From ea17e7dbfba0a885c85d72f32c13c23810882791 Mon Sep 17 00:00:00 2001 From: Roland Mainz <roland.mainz@nrubsig.org> Date: Fri, 31 Jan 2025 16:20:31 +0100 Subject: [PATCH 5/5] cygwin: msnfs41client: Add "attach_debugger_to_daemon" subcmd Add a "attach_debugger_to_daemon" subcmd to msnfs41client.bash for attaching a debugger (WinDBG's cdb) to a running nfsd.exe Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com> --- cygwin/devel/msnfs41client.bash | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/cygwin/devel/msnfs41client.bash b/cygwin/devel/msnfs41client.bash index 92171fd..a46e7f7 100755 --- a/cygwin/devel/msnfs41client.bash +++ b/cygwin/devel/msnfs41client.bash @@ -651,6 +651,25 @@ function nfsclient_system_rundeamon return $? } +function attach_debugger_to_daemon +{ + set -o nounset + set -o xtrace + set -o errexit + + typeset nfsd_winpid + typeset dummy + + export NT_ALT_SYMBOL_PATH="$(cygpath -w "$PWD");srv*https://msdl.microsoft.com/download/symbols" + + # Get Windows pid of nfsd.exe + read dummy nfsd_winpid < <(tasklist /FI "IMAGENAME eq nfsd.exe" /FO list | fgrep 'PID:') + + cdb '-c' '!gflag +soe;sxe -c "kp;gn" *;.lines -e;g' -p ${nfsd_winpid} + + return $? +} + function watch_kernel_debuglog { typeset dbgview_cmd @@ -946,6 +965,19 @@ function main return $? ;; # misc + 'attach_debugger_to_daemon') + check_machine_arch || (( numerr++ )) + require_cmd 'tasklist.exe' || (( numerr++ )) + require_cmd 'cdb.exe' || (( numerr++ )) + if ! is_windows_admin_account ; then + printf $"%s: %q requires Windows Adminstator permissions.\n" "$0" "$cmd" + (( numerr++ )) + fi + (( numerr > 0 )) && return 1 + + attach_debugger_to_daemon + return $? + ;; 'watch_kernel_debuglog') check_machine_arch || (( numerr++ )) case "$(uname -m)" in -- 2.45.1

Title:

Privacy: Public Private

How long should your post be retained?

15 mins an hour a day a week a month forever

All content is user-submitted.
The administrators of this site (kpaste.net) are not responsible for their content.
Abuse reports should be emailed to us at