igb_avb: 0002-Disable-pci_-_pcie_error_reporting-for-Linux-kernels.patch
Posted by Anonymous on Thu 14th Dec 2023 15:31
raw | new post

From 60aa3f8321e3bbbb102d6e40f4b623444350d7d7 Mon Sep 17 00:00:00 2001
From: Roland Mainz <roland.mainz@nrubsig.org>
Date: Tue, 12 Dec 2023 15:12:56 +0100
Subject: [PATCH] Disable |pci_*_pcie_error_reporting()| for Linux kernels >=
 6.6.0

|pci_enable_pcie_error_reporting()| enables the device to send ERR_*
Messages.  Since commit #f26e58bf6f54 ("PCI/AER: Enable error
reporting when AER is native"), the PCI core does this for all
devices during enumeration, so this is no longer needed in igb_avb.

So disable the redundant |pci_enable_pcie_error_reporting()| and
|pci_disable_pcie_error_reporting()| calls for Linux kernels >= 6.6.0

Note that this doesn't control interrupt generation by the Root Port;
that is controlled by the AER Root Error Command register, which is
managed by the AER service driver.

Signed-off-by: Marvin Wenzel <marvin.wenzel@rovema.de>
---
 kmod/igb_main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kmod/igb_main.c b/kmod/igb_main.c
index 5d4c6db..0d51176 100755
--- a/kmod/igb_main.c
+++ b/kmod/igb_main.c
@@ -2743,7 +2743,10 @@ static int igb_probe(struct pci_dev *pdev,
        if (err)
                goto err_pci_reg;

+
+#if ( LINUX_VERSION_CODE < KERNEL_VERSION(6,6,0) )
        pci_enable_pcie_error_reporting(pdev);
+#endif

        pci_set_master(pdev);

@@ -3307,7 +3310,9 @@ static void igb_remove(struct pci_dev *pdev)
        mutex_destroy(&adapter->lock);
        free_netdev(netdev);

+#if ( LINUX_VERSION_CODE < KERNEL_VERSION(6,6,0) )
        pci_disable_pcie_error_reporting(pdev);
+#endif

        pci_disable_device(pdev);
 }
--
2.30.2