nfs_mount: Document sec=sys and allow Windows-style /? help
Posted by Anonymous on Wed 4th Oct 2023 13:11
raw | new post

From 91aaed7459a37332b59543c446e5d3f1a862c34c Mon Sep 17 00:00:00 2001
From: Roland Mainz <roland.mainz@nrubsig.org>
Date: Wed, 4 Oct 2023 13:24:45 +0200
Subject: [PATCH] nfs_mount: Document sec=sys and allow Windows-style /? help

Update usage message for nfs_mount.exe (feedback by Joshua Hurst):
- Document sec=sys
- Print usage messsage for Windows-style /?, so that Windows admins
have it a bit easier

Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
---
 mount/mount.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/mount/mount.c b/mount/mount.c
index f2d5650..ed30781 100644
--- a/mount/mount.c
+++ b/mount/mount.c
@@ -65,7 +65,7 @@ static VOID PrintUsage(LPTSTR pProcess)
         TEXT("\tport=#\tTCP port to use (defaults to 2049)\n")
         TEXT("\trsize=#\tread buffer size in bytes\n")
         TEXT("\twsize=#\twrite buffer size in bytes\n")
-        TEXT("\tsec=krb5:krb5i:krb5p\tspecify gss security flavor\n")
+        TEXT("\tsec=sys:krb5:krb5i:krb5p\tspecify (gss) security flavor\n")
         TEXT("\twritethru\tturns off rdbss caching for writes\n")
         TEXT("\tnocache\tturns off rdbss caching\n")
         TEXT("\ttimeout=#\tspecify upcall timeout value in seconds (default 120s)\n")
@@ -146,7 +146,13 @@ DWORD __cdecl _tmain(DWORD argc, LPTSTR argv[])
                 _ftprintf(stderr, TEXT("Unrecognized option ")
                     TEXT("'%s', disregarding.\n"), argv[i]);
         }
-        else if (pLocalName == NULL) /* drive letter */
+        else if (_tcscmp(argv[i], TEXT("/?")) == 0)
+       {
+           /* Windows-style "nfs_mount /?" help */
+            PrintUsage(argv[0]);
+            goto out;
+       }
+       else if (pLocalName == NULL) /* drive letter */
         {
             pLocalName = argv[i];
         }
--
2.39.0