pastebin - collaborative debugging tool
rovema.kpaste.net RSS


msnfs41client: Patches for VS2022 make install, 32bit nfs_mount.exe on 64bit Windows+misc, 2024-11-20
Posted by Anonymous on Wed 20th Nov 2024 17:29
raw | new post

  1. From 7e76960f1835c5f4a1f00ec70222618e205c23cf Mon Sep 17 00:00:00 2001
  2. From: Roland Mainz <roland.mainz@nrubsig.org>
  3. Date: Wed, 20 Nov 2024 17:41:03 +0100
  4. Subject: [PATCH 1/3] cygwin: Makefile.install: Fix *.dll copy for VS2022
  5.  
  6. Fix *.dll copy in cygwin/Makefile.install for Visual Studio 2022
  7.  
  8. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  9. ---
  10. cygwin/Makefile.install | 8 ++++++--
  11.  1 file changed, 6 insertions(+), 2 deletions(-)
  12.  
  13. diff --git a/cygwin/Makefile.install b/cygwin/Makefile.install
  14. index 019f038..4fda8f5 100644
  15. --- a/cygwin/Makefile.install
  16. +++ b/cygwin/Makefile.install
  17. @@ -103,14 +103,18 @@ installdest:
  18.         [[ -x $(CYGWIN_BASEPATH)/bin/shcomp.exe ]] && cp -f $(CYGWIN_BASEPATH)/bin/shcomp.exe $(DESTDIR)/$(CYGWIN_BASEPATH)/bin/shcomp.exe || true
  19.         cp $(PROJECT_BASEDIR_DIR)/cygwin/cygwin_ksh93/ksh.kshrc $(DESTDIR)/$(CYGWIN_BASEPATH)/etc/ksh.kshrc
  20.         @ printf '# Packaging libs\n'
  21. +       set -o errexit -o pipefail ; \
  22. +       typeset msbuildpath="$$(which MSBuild.exe)" ; \
  23. +       typeset vsbasepath="$${msbuildpath%*/Community/*}" ; \
  24. +       test -d "$${vsbasepath}" || { printf "vsbasepath not found\n" 1>&2 ; exit 1 ; }; \
  25.         if [[ "$(CYGWIN_BASEPATH)" == *64* ]] ; then \
  26.                 cp \
  27. -                       "$$(find '/cygdrive/c/Program Files (x86)/Microsoft Visual Studio/2019/Community' -ipath '*/x64/*/VCRUNTIME140D.dll' | head -n 1)" \
  28. +                       "$$(find "$${vsbasepath}/Community" -ipath '*/x64/*/VCRUNTIME140D.dll' | sort -n -r | head -n 1)" \
  29.                         $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/. ; \
  30.                 cp '/cygdrive/c/Program Files (x86)/Windows Kits/10/bin/x64/ucrt/ucrtbased.dll' $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/. ; \
  31.         else \
  32.                 cp \
  33. -                       "$$(find '/cygdrive/c/Program Files (x86)/Microsoft Visual Studio/2019/Community' -ipath '*/x86/*/VCRUNTIME140D.dll' | head -n 1)" \
  34. +                       "$$(find "$${vsbasepath}/Community" -ipath '*/x86/*/VCRUNTIME140D.dll' | sort -n -r | head -n 1)" \
  35.                         $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/. ; \
  36.                 cp '/cygdrive/c/Program Files (x86)/Windows Kits/10/bin/x86/ucrt/ucrtbased.dll' $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/. ; \
  37.         fi
  38. --
  39. 2.45.1
  40.  
  41. From 23d2b7c7492c13ff662d3114a1f0c9f662cdde15 Mon Sep 17 00:00:00 2001
  42. From: Roland Mainz <roland.mainz@nrubsig.org>
  43. Date: Wed, 20 Nov 2024 18:00:03 +0100
  44. Subject: [PATCH 2/3] cygwin: Install 32bit nfs_mount.exe to assist debugging
  45.  32bit apps on 64bit Windows
  46.  
  47. Install 32bit nfs_mount.exe as /sbin/nfs_mount.i686.exe and
  48. /sbin/nfs_umount.i686.exe to assist debugging 32bit apps on 64bit
  49. Windows.
  50.  
  51. Reported-by: Mark Liam Brown <brownmarkliam@gmail.com>
  52. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  53. ---
  54. cygwin/Makefile         | 4 ++++
  55.  cygwin/Makefile.install | 6 ++++++
  56.  2 files changed, 10 insertions(+)
  57.  
  58. diff --git a/cygwin/Makefile b/cygwin/Makefile
  59. index 0775b24..43813de 100644
  60. --- a/cygwin/Makefile
  61. +++ b/cygwin/Makefile
  62. @@ -102,6 +102,8 @@ installdest32: \
  63.         make -f $(CYGWIN_MAKEFILE_DIR)/Makefile.install \
  64.                 installdest \
  65.                 VS_BUILD_DIR="$(VS_BUILD_DIR32)" \
  66. +               VS_BUILD_DIR32="$(VS_BUILD_DIR32)" \
  67. +               VS_BUILD_DIR64="$(VS_BUILD_DIR64)" \
  68.                 CYGWIN_BASEPATH=/cygdrive/c/cygwin/
  69.  
  70.  # installdest64: 32bit nfs41_np.dll is required to support 32bit
  71. @@ -118,6 +120,8 @@ installdest64: \
  72.         make -f $(CYGWIN_MAKEFILE_DIR)/Makefile.install \
  73.                 installdest \
  74.                 VS_BUILD_DIR="$(VS_BUILD_DIR64)" \
  75. +               VS_BUILD_DIR32="$(VS_BUILD_DIR32)" \
  76. +               VS_BUILD_DIR64="$(VS_BUILD_DIR64)" \
  77.                 CYGWIN_BASEPATH=/cygdrive/c/cygwin64/
  78.  
  79.  # installdest: we need a .WAIT here becase Makefile.install uses git commands
  80. diff --git a/cygwin/Makefile.install b/cygwin/Makefile.install
  81. index 4fda8f5..07a55f6 100644
  82. --- a/cygwin/Makefile.install
  83. +++ b/cygwin/Makefile.install
  84. @@ -41,6 +41,12 @@ installdest:
  85.         cp -r $(VS_BUILD_DIR)/nfs_mount.*       $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  86.         # we need a hardlink for nfs_umount.exe, softlinks do not work
  87.         ln -f $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.exe  $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_umount.exe
  88. +       # install 32bit nfs_mount.exe on 64bit Windows to assist with debugging 32bit issues
  89. +       # we use the "Release" version to avoid issues with missing debug libraries
  90. +       if [[ "$(CYGWIN_BASEPATH)" == *64* ]] ; then \
  91. +               cp $(VS_BUILD_DIR32)/../Release/nfs_mount.exe   $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.i686.exe ; \
  92. +               ln -f $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.i686.exe     $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_umount.i686.exe ; \
  93. +       fi
  94.         cp -r $(VS_BUILD_DIR)/nfsd.*            $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  95.         cp -r $(VS_BUILD_DIR)/nfs_install.*     $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  96.         cp -r $(VS_BUILD_DIR)/libtirpc.*        $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  97. --
  98. 2.45.1
  99.  
  100. From 7cf017d3d2289f3f99894f4e76711e99ab0f6472 Mon Sep 17 00:00:00 2001
  101. From: Roland Mainz <roland.mainz@nrubsig.org>
  102. Date: Wed, 20 Nov 2024 18:08:04 +0100
  103. Subject: [PATCH 3/3] cygwin: Remove cp option "-r" for non-directories
  104.  
  105. Remove cp option "-r" for non-directories
  106.  
  107. Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
  108. ---
  109. cygwin/Makefile.install | 16 ++++++++--------
  110.  1 file changed, 8 insertions(+), 8 deletions(-)
  111.  
  112. diff --git a/cygwin/Makefile.install b/cygwin/Makefile.install
  113. index 07a55f6..b973635 100644
  114. --- a/cygwin/Makefile.install
  115. +++ b/cygwin/Makefile.install
  116. @@ -36,9 +36,9 @@ installdest:
  117.         mkdir -p $(DESTDIR)/$(CYGWIN_BASEPATH)/usr/share/msnfs41client
  118.         mkdir -p $(DESTDIR)/$(CYGWIN_BASEPATH)/usr/share/msnfs41client/tests
  119.         mkdir -p $(DESTDIR)/$(CYGWIN_BASEPATH)/usr/share/msnfs41client/tests/misc
  120. -       cp -r $(VS_BUILD_DIR)/nfsd.exe          $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfsd_debug.exe
  121. -       cp -r $(VS_BUILD_DIR)/nfsd.pdb          $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfsd_debug.pdb
  122. -       cp -r $(VS_BUILD_DIR)/nfs_mount.*       $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  123. +       cp $(VS_BUILD_DIR)/nfsd.exe             $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfsd_debug.exe
  124. +       cp $(VS_BUILD_DIR)/nfsd.pdb             $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfsd_debug.pdb
  125. +       cp $(VS_BUILD_DIR)/nfs_mount.*  $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  126.         # we need a hardlink for nfs_umount.exe, softlinks do not work
  127.         ln -f $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.exe  $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_umount.exe
  128.         # install 32bit nfs_mount.exe on 64bit Windows to assist with debugging 32bit issues
  129. @@ -47,11 +47,11 @@ installdest:
  130.                 cp $(VS_BUILD_DIR32)/../Release/nfs_mount.exe   $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.i686.exe ; \
  131.                 ln -f $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_mount.i686.exe     $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/nfs_umount.i686.exe ; \
  132.         fi
  133. -       cp -r $(VS_BUILD_DIR)/nfsd.*            $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  134. -       cp -r $(VS_BUILD_DIR)/nfs_install.*     $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  135. -       cp -r $(VS_BUILD_DIR)/libtirpc.*        $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  136. -       cp -r $(VS_BUILD_DIR)/nfs41_np.*        $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  137. -       cp -r $(VS_BUILD_DIR)/nfs41_driver.*    $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  138. +       cp $(VS_BUILD_DIR)/nfsd.*               $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  139. +       cp $(VS_BUILD_DIR)/nfs_install.*        $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  140. +       cp $(VS_BUILD_DIR)/libtirpc.*   $(DESTDIR)/$(CYGWIN_BASEPATH)/sbin/.
  141. +       cp $(VS_BUILD_DIR)/nfs41_np.*   $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  142. +       cp $(VS_BUILD_DIR)/nfs41_driver.*       $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  143.         cp $(PROJECT_BASEDIR_DIR)/nfs41rdr.inf  $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  144.         cp $(PROJECT_BASEDIR_DIR)/etc_netconfig $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  145.         cp $(PROJECT_BASEDIR_DIR)/ms-nfs41-idmap.conf           $(DESTDIR)/$(CYGWIN_BASEPATH)/lib/msnfs41client/.
  146. --
  147. 2.45.1

Submit a correction or amendment below (click here to make a fresh posting)
After submitting an amendment, you'll be able to view the differences between the old and new posts easily.

Syntax highlighting:

To highlight particular lines, prefix each line with {%HIGHLIGHT}




All content is user-submitted.
The administrators of this site (kpaste.net) are not responsible for their content.
Abuse reports should be emailed to us at