rovema.kpaste.net RSS- From 8684a23d8f90f2b2ec434a73def8398fa1e24028 Mon Sep 17 00:00:00 2001
- From: Roland Mainz <roland.mainz@nrubsig.org>
- Date: Thu, 6 Feb 2025 20:45:16 +0100
- Subject: [PATCH] sys,tests: Reading POSIX symlink to /dev should be
- passed-through unchanged
- Reading POSIX symlink to /dev should be passed-through unchanged. Cygwin
- creates symlinks to /dev/null, /dev/zero, /dev/stdin, and expects
- to read them back 1:1.
- Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
- ---
- sys/nfs41sys_symlink.c | 50 ++++++++++++++++++++++++++++++++++++++++
- tests/manual_testing.txt | 2 ++
- 2 files changed, 52 insertions(+)
- diff --git a/sys/nfs41sys_symlink.c b/sys/nfs41sys_symlink.c
- index 8f4447b..442b883 100644
- --- a/sys/nfs41sys_symlink.c
- +++ b/sys/nfs41sys_symlink.c
- @@ -598,6 +598,56 @@ NTSTATUS nfs41_GetSymlinkReparsePoint(
- "got TargetName='%wZ', len=%d\n",
- &TargetName, (int)TargetName.Length);
- + /*
- + * Cygwin: Pass-through for POSIX symlinks to /dev, e.g.
- + * /dev/null, /dev/zero, /dev/stdin etc.
- + * Otherwise code like
- + * $ ln -s /dev/zero foo && ls -l foo && rm foo #
- + * will fail.
- + * We restrict this to /dev only, all other kind of POSIX
- + * symlinks should be translated to Win32 symlink syntax
- + */
- + if (((TargetName.Length > 5*sizeof(wchar_t)) &&
- + (!wcsncmp(TargetName.Buffer, L"/dev/", 5)))) {
- + const USHORT HeaderLen = FIELD_OFFSET(REPARSE_DATA_BUFFER,
- + SymbolicLinkReparseBuffer.PathBuffer);
- +
- + DbgP("nfs41_GetSymlinkReparsePoint: "
- + "Cygwin /dev/ symlink codepath\n");
- +
- + /* Copy data into FsCtl buffer */
- + (void)memcpy(((PBYTE)FsCtl->pOutputBuffer + HeaderLen),
- + TargetName.Buffer, TargetName.Length);
- + TargetName.Buffer =
- + (PWCH)((PBYTE)FsCtl->pOutputBuffer + HeaderLen);
- +
- + DbgP("nfs41_GetSymlinkReparsePoint: "
- + "Cygwin /dev/ symlink TargetName='%wZ'\n",
- + &TargetName);
- +
- + Reparse->ReparseTag = IO_REPARSE_TAG_SYMLINK;
- + Reparse->ReparseDataLength = HeaderLen + TargetName.Length -
- + REPARSE_DATA_BUFFER_HEADER_SIZE;
- + Reparse->Reserved = 0;
- + /* Cygwin wants |SYMLINK_FLAG_RELATIVE| for these symlinks */
- + Reparse->SymbolicLinkReparseBuffer.Flags =
- + SYMLINK_FLAG_RELATIVE;
- +
- + /* PrintName and SubstituteName point to the same string */
- + Reparse->SymbolicLinkReparseBuffer.SubstituteNameOffset = 0;
- + Reparse->SymbolicLinkReparseBuffer.SubstituteNameLength =
- + TargetName.Length;
- + Reparse->SymbolicLinkReparseBuffer.PrintNameOffset = 0;
- + Reparse->SymbolicLinkReparseBuffer.PrintNameLength =
- + TargetName.Length;
- +
- + print_reparse_buffer(Reparse);
- +
- + RxContext->IoStatusBlock.Information =
- + (ULONG_PTR)HeaderLen + TargetName.Length;
- + goto out;
- + }
- +
- /* POSIX slash to Win32 backslash */
- size_t i;
- for (i=0 ; i < TargetName.Length ; i++) {
- diff --git a/tests/manual_testing.txt b/tests/manual_testing.txt
- index 173c753..6957e0e 100644
- --- a/tests/manual_testing.txt
- +++ b/tests/manual_testing.txt
- @@ -183,6 +183,8 @@ powershell -Command 'New-Item -Path sym_mypsfile1 -ItemType SymbolicLink -Value
- mkdir targetdir1
- cmd /C 'mklink /D targetdir1_sym targetdir1'
- cmd /C 'mklink /D targetdir2_sym .\targetdir1'
- +# 6. Cygwin /dev/ symlinks, e.g. foo --> /dev/null
- +ln -s /dev/zero foo && ls -l foo && rm foo
- #
- # Tests for groups
- --
- 2.45.1
msnfs41client: Win32 reading symlink should pass-through POSIX /dev-symlinks unchanged, 2025-02-06
Posted by Anonymous on Thu 6th Feb 2025 20:08
raw | new post
Submit a correction or amendment below (click here to make a fresh posting)
After submitting an amendment, you'll be able to view the differences between the old and new posts easily.